Add the option to submit for review#23
Open
EdoardoCostantini wants to merge 5 commits intoIQSS:masterfrom
Open
Add the option to submit for review#23EdoardoCostantini wants to merge 5 commits intoIQSS:masterfrom
EdoardoCostantini wants to merge 5 commits intoIQSS:masterfrom
Conversation
Member
|
@EdoardoCostantini hi! I don't think anyone has been looking at new pull requests coming in. I just subscribed to "all activity" so hopefully I'll notice next time. Are you still interested in this? Sorry for the long delay! |
Author
Member
|
@EdoardoCostantini ok, thanks. I tried the action myself and couldn't get it to work at all so I put out a release that does work for me, at least: https://github.com/IQSS/dataverse-uploader/releases/tag/v1.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, dataverse-uploader maintainers👋. To address issue #17, I gave a shot at implementing an option to submit the dataset for review. I added a new optional argument called
REVIEW. When set toTRUE, the action automatically submits the dataset for review upon upload. I think it makes sense to keep this option separate from thePUBLISHone, but let me know what you think. I can always adjust things to have a single argument if you prefer.I also thought it would be desirable to prevent any attempt to change the content by the action if the dataset is being reviewed. So, I added a check to stop the action if the targeted dataset is already under review.