Skip to content

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Oct 20, 2025

What this PR does / why we need it:

Following up on @pdurbin's work in #845, this PR updates how users select the dataset type in the dataset creation flow.
For now, we’ve hardcoded the dataset type descriptions (“dataset” and “review”) as a temporary solution until the new field is added.
This is the first step toward supporting dataset types in the SPA, more enhancements coming soon.

Storybook links:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

  1. Login within the SPA and navigate to the Create Dataset page.
  2. By default only one dataset type exists('dataset' type) so you won't see a Dataset Type selector.
  3. Add a new dataset type with:
curl -H "X-Dataverse-key:$API_TOKEN" -H "Content-Type: application/json" "http://localhost:8080/api/datasets/datasetTypes" -X POST -d '{"name":"review","linkedMetadataBlocks":["geospatial"]}'
  1. Navigate again to the Create Dataset Page and now you will see a Dataset Type selector.
  2. Select "Review" and create the dataset.
  3. Go to edit the recently created dataset and you will se a Dataset Type readonly field with the value of "Review".

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes.

Create Dataset Page, Dataset Type selector.
Screenshot 2025-10-21 at 14 30 25

Edit Dataset Page, Dataset Type readonly field.
Screenshot 2025-10-21 at 14 31 30

Is there a release notes or changelog update needed for this change?:

Not for now, might be good to add it after work related to dataset types is done.

Additional documentation:

@github-actions github-actions bot added the GREI Re-arch GREI re-architecture-related label Oct 20, 2025
@coveralls
Copy link

coveralls commented Oct 20, 2025

Coverage Status

coverage: 97.708% (-0.08%) from 97.787%
when pulling d25628f on 797-dataset-type-selection-step
into 012e15c on develop.

@pdurbin
Copy link
Member

pdurbin commented Oct 22, 2025

For now, we’ve hardcoded the dataset type descriptions (“dataset” and “review”) as a temporary solution until the new field is added.

As I mentioned at standup I added the "waiting" label until we've addressed the above. I'll hold on to this issue.

Update: we'll use this issue to track adding "description":

Thanks for the PR, @g-saracca! It looks great!

@cmbz cmbz added FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) labels Oct 22, 2025
@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@pdurbin pdurbin moved this from In Review 🔎 to In Progress 💻 in IQSS Dataverse Project Nov 6, 2025
@cmbz cmbz added the FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) label Nov 22, 2025
@pdurbin pdurbin assigned jp-tosca and unassigned pdurbin Nov 24, 2025
@cmbz cmbz added the FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) label Dec 3, 2025
@cmbz cmbz added the FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) label Dec 17, 2025
@cmbz cmbz added the FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) label Dec 31, 2025
@pdurbin
Copy link
Member

pdurbin commented Jan 12, 2026

I'm removing the "waiting" label because descriptions of dataset types are now available in the image built from this PR:

As a reminder, in the frontend (this PR) these descriptions are currently hard-coded to the values in the screenshot below. They should be retrieved dynamically from the backend instead.

503802796-56cac277-054d-4ee6-90a7-b7a376decc12 (2)

@pdurbin pdurbin removed the Waiting label Jan 12, 2026
@jp-tosca jp-tosca assigned jp-tosca and unassigned jp-tosca Jan 12, 2026
@jp-tosca jp-tosca moved this from In Progress 💻 to SPRINT READY in IQSS Dataverse Project Jan 12, 2026
@pdurbin pdurbin self-assigned this Jan 12, 2026
@pdurbin pdurbin moved this from SPRINT READY to In Progress 💻 in IQSS Dataverse Project Jan 12, 2026
@pdurbin pdurbin marked this pull request as draft January 12, 2026 19:06
Conflicts:
package-lock.json
package.json
src/dataset/domain/repositories/DatasetRepository.ts
src/stories/dataset/DatasetErrorMockRepository.ts
src/stories/dataset/DatasetMockRepository.ts
@pdurbin pdurbin added the Size: 50 A percentage of a sprint. 35 hours. label Jan 14, 2026
@cmbz cmbz added the FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) GREI Re-arch GREI re-architecture-related Project: Trusted Data Size: 50 A percentage of a sprint. 35 hours.

Projects

Status: In Progress 💻

Development

Successfully merging this pull request may close these issues.

Allow for the creation of various dataset types

6 participants