Bugfix corrupted cache #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2024 13:14
…(1.7GB) in case of currupted cache file
Author
|
Attached corrupted cache |
Contributor
|
Hi Dmitrii. I don't think we can just limit all messages to 32MB. Lots of CFX users have messages that exceed this size. Why do you believe the large message corrupted the cache? Is there a repeatable re-create procedure to make this happen? |
Author
|
Hi @johnjwalls, I missed your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that at application start memory consumption jumped to 1.7GB
Reason is corrupted cache file in %LocalAppData%\Temp
which lead to invalid number of bytes to be read from file in CFXEnvelope.ReadRecord
BinaryReader.ReadBytes(len) always create buffer byte array with requested len.
Proposal is to limit maximum allowed CFXMessage size to 32MB
In case message in BinaryReader is bigger - invalidate cache.