Refactor API and Transform Layers for Shared Configuration and Simplified Logic#15
Closed
ismailtsdln wants to merge 1 commit intoINTERPOL-Innovation-Centre:mainfrom
Closed
Refactor API and Transform Layers for Shared Configuration and Simplified Logic#15ismailtsdln wants to merge 1 commit intoINTERPOL-Innovation-Centre:mainfrom
ismailtsdln wants to merge 1 commit intoINTERPOL-Innovation-Centre:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Layer Refactor
GraphSenseClient (Singleton Pattern)
Introduced a singleton class to manage API configuration and client instances.
Ensures configuration is loaded only once and shared across all transforms.
Eliminates redundant client initialization and improves consistency.
Improved Entity Creation
Completely rewrote the create_entity_with_details function to be more robust and maintainable.
Handles different query types consistently.
Replaced dictionary indexing with explicit object attributes for improved type safety and readability.
Configuration Factorization
Centralized currency-specific constants (e.g., Satoshi / Wei conversion factors) into a standard configuration dictionary.
Improved consistency and ease of maintenance for currency-related calculations.
Transform Layer Refactor
Centralized Extraction Logic
Moved common address and currency extraction logic into transforms/utils.py.
All transforms now rely on extract_address_and_currencies, which uniformly handles:
Cluster IDs
Explicit currency filters
Automatic currency detection
Simplified Transforms
Significantly simplified ToDetails.py, ToTags.py, and ToCluster.py.
Removed repetitive boilerplate related to property extraction and error handling.
Delegated shared logic and error display to utility functions, improving readability and maintainability.