Skip to content

Fix/grid3d coordinate leakage #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divye-joshi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/grid3d coordinate leakage #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d27da
fix: use floor division in grid3d to prevent coordinate leakage
divye-joshi Jan 30, 2026
b3282a7
fix: extra lines
divye-joshi Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions csa/geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ def grid3d(width, xScale = 1.0, yScale = 1.0, zScale = 1.0, x0 = 0.0, y0 = 0.0,
yScale /= width
zScale /= width
g = lambda i: \
(x0 + xScale * (i % width), y0 + yScale * ((i % (width*width)) / width), z0 + zScale * (i / (width*width)))
(x0 + xScale * (i % width),
y0 + yScale * ((i % (width*width)) // width),
z0 + zScale * (i // (width*width)))
g.type = 'grid3d'
g.width = width
g.xScale = xScale
Expand Down Expand Up @@ -168,4 +170,4 @@ def euclidMetric3d (g1, g2 = None):
:rtype: function
"""
g2 = g1 if g2 == None else g2
return lambda i, j: euclidDistance3d (g1 (i), g2 (j))
return lambda i, j: euclidDistance3d (g1 (i), g2 (j))