Lo: CG Map Normalizing 'energy_sc' #2541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing psets into a map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
We found an issue when trying to generate L3 HF maps from Lo HF maps. We found that the energy_sc values being computed were far larger than we would expect. All energy_sc values were being summed together and then not normalized after being projected into the map. We chose to do this with an exposure weighting to match Hi, but we are not sure if this is what the Lo team actually wants. It did yield a map that has reasonable looking values.
You'll notice that there is no test coverage for this fix, as we don't intend for this PR to be merged as is but we didn't want it to get lost over the holiday break.
Overview
In lo_l2.py, before projecting pset values to a map, multiply the energy_sc by exposure_factor. After projection, divide the exposure_factor back out.