Hard code IMAP_SPACECRAFT ID and IMAP_SCLK ID #2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
approved these changes
Dec 22, 2025
Collaborator
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Did one of our kernels change under the hood without us realizing it?
subagonsouth
merged commit 8848e13
into
IMAP-Science-Operations-Center:dev
14 checks passed
subagonsouth
deleted the
2532-bug---pointing-attitude-mean-spin-axis-is-wrong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
I don't know why these errors started showing up after the PR to fix how the mean spin axis was merged. I also can't reproduce locally. The spacecraft ID and clock ID should never change, so I don't think that it is a problem to hard code these. They are used as hard coded values elsewhere anyway.