Skip to content

Add all accepted ILIAS 12 NPM dependency PRs into package.json#11262

Open
lscharmer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
lscharmer:12/npm-dependency-merge
Open

Add all accepted ILIAS 12 NPM dependency PRs into package.json#11262
lscharmer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
lscharmer:12/npm-dependency-merge

Conversation

@lscharmer
Copy link
Contributor

Hi,
this PR merges all accepted ILIAS 12 NPM dependencies.

The following PRs are included:

For root package.json:

For components/ILIAS/Chatroom/chat/package.json:

Missing dependencies

Chart.js

Used for the Chart UI Component.

@thibsy can you look into this?

I removed the corresponding code in order for the setup process to work for now.

JSTree

Used in the ilExplorerBaseGUI (part of the UIComponent).

@thibsy can you look into this?

I removed the corresponding code in order for the setup process to work for now.

Things to note

eslint + eslint-config-airbnb-base

This is the same issue as mentioned in: #9086
The package eslint-config-airbnb-base requires an out of date version of eslint (https://eslint.org/version-support/).

I opt for dropping it for now.

@thibsy I hope this is ok for you.

rollup on Mac

As mentioned & fixed by @thibsy in #9361, some packages (e.g. for mac) where not included with the normal npm install to create the package-lock.json.

Even though I created the package-lock.json the same way as last year, this time the packages are already included AFAIK:

# This PRs and output after PR #9361, are the same
$ grep rollup-darwin package-lock.json
    "node_modules/@rollup/rollup-darwin-arm64": {
      "resolved": "https://registry.npmjs.org/@rollup/rollup-darwin-arm64/-/rollup-darwin-arm64-4.53.3.tgz",
    "node_modules/@rollup/rollup-darwin-x64": {
      "resolved": "https://registry.npmjs.org/@rollup/rollup-darwin-x64/-/rollup-darwin-x64-4.53.3.tgz",
	"@rollup/rollup-darwin-arm64": "4.53.3",
	"@rollup/rollup-darwin-x64": "4.53.3",

vs. package-lock.json before PR #9361:

$ grep rollup-darwin package-lock.json
        "@rollup/rollup-darwin-arm64": "4.38.0",
        "@rollup/rollup-darwin-x64": "4.38.0",

@thibsy it would be great if you could verify this, I will test this too as soon as I have a Mac available.

Fixing Unit Tests

The change made in: components/ILIAS/UI/tests/Client/Table/Presentation/presentation.table.test.js fixes an endless loop error. With this change all JS Unit Tests run successfully.

Summary

In comparison to ILIAS 11:

New dependencies: None

Removed dependencies:

@lscharmer lscharmer requested a review from thibsy March 13, 2026 11:26
@lscharmer lscharmer added technical board dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code technical board

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant