Add all accepted ILIAS 12 NPM dependency PRs into package.json#11262
Open
lscharmer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
Open
Add all accepted ILIAS 12 NPM dependency PRs into package.json#11262lscharmer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
lscharmer wants to merge 1 commit intoILIAS-eLearning:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR merges all accepted ILIAS 12 NPM dependencies.
The following PRs are included:
For root
package.json:@yaireo/tagifyas npm Dependency for ILIAS 12 #10663dropzoneas npm Dependency for ILIAS 12 #10664@rollup/plugin-node-resolveas npm Dependency for ILIAS 12 #10665@rollup/plugin-terseras npm Dependency for ILIAS 12 #10666eslintas npm Dependency for ILIAS 12 #10667eslint-config-airbnb-baseas npm Dependency for ILIAS 12 #10668eslint-plugin-importas npm Dependency for ILIAS 12 #10669jsdomas npm Dependency for ILIAS 12 #10670rollupas npm Dependency for ILIAS 12 #10671sassas npm Dependency for ILIAS 12 #10672webui-popoverfor ILIAS 12 #10633mathjaxfor ILIAS 12 #10624linkifyjsandlinkify-elementfor ILIAS 12 #10569jqueryfor ILIAS 12 #10567For
components/ILIAS/Chatroom/chat/package.json:winston#10566uuid#10565socket.ioandsocket.io-client#10564mariadb#10563express#10559Missing dependencies
Chart.js
Used for the
ChartUI Component.@thibsy can you look into this?
I removed the corresponding code in order for the setup process to work for now.
JSTree
Used in the
ilExplorerBaseGUI(part of theUIComponent).@thibsy can you look into this?
I removed the corresponding code in order for the setup process to work for now.
Things to note
eslint+eslint-config-airbnb-baseThis is the same issue as mentioned in: #9086
The package
eslint-config-airbnb-baserequires an out of date version ofeslint(https://eslint.org/version-support/).I opt for dropping it for now.
@thibsy I hope this is ok for you.
rollupon MacAs mentioned & fixed by @thibsy in #9361, some packages (e.g. for mac) where not included with the normal
npm installto create thepackage-lock.json.Even though I created the
package-lock.jsonthe same way as last year, this time the packages are already included AFAIK:vs.
package-lock.jsonbefore PR #9361:$ grep rollup-darwin package-lock.json "@rollup/rollup-darwin-arm64": "4.38.0", "@rollup/rollup-darwin-x64": "4.38.0",@thibsy it would be great if you could verify this, I will test this too as soon as I have a Mac available.
Fixing Unit Tests
The change made in:
components/ILIAS/UI/tests/Client/Table/Presentation/presentation.table.test.jsfixes an endless loop error. With this change all JS Unit Tests run successfully.Summary
In comparison to ILIAS 11:
New dependencies: None
Removed dependencies: