[Admin] 46680: Footerlink „Technische Betreuung kontaktieren“#10834
Open
fneumann wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
[Admin] 46680: Footerlink „Technische Betreuung kontaktieren“#10834fneumann wants to merge 1 commit intoILIAS-eLearning:release_10from
fneumann wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
fneumann
force-pushed
the
fix10-mantis46680-contact-link
branch
from
5188006 to
28d9f33
Compare
fneumann
requested review from
lscharmer
and removed request for
mjansenDatabay
lscharmer
requested changes
Mar 18, 2026
| if (!empty(ilSystemSupportContacts::getValidSupportContactIds())) { | ||
| return $DIC->ctrl()->getLinkTargetByClass(self::class); | ||
| } | ||
| return ''; |
Contributor
There was a problem hiding this comment.
Please return null, so that the Link is hidden if it is not present.
An empty string will result in a broken link.
See:
Also the buildURI call can be readded as well (but only a suggestion as this is a bugfix): ae7301f#diff-413f26f1852286d88624d2da1c0d7a70d1a68683b82b6c30f0583c30b003eb67R102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=46680
This PR removes the workaround of showing a "mailto:" address in the footer to anonymous user, since:
If technical contacts are configured, the link in the footer will always lead to a GUI for showing them.
If a user is not logged in and global profiles are disabled for anonymous access, the GUI will just list the e-mail addresses of the technical contacts, even if they haven't published their profiles. This equals to the previous behavior and to their usage for "mailto:" links in the self registration and the user agreement.