Add support for value set.filter operator.equal#689
Closed
edwardlo12 wants to merge 11 commits intoIHTSDO:developfrom
Closed
Add support for value set.filter operator.equal#689edwardlo12 wants to merge 11 commits intoIHTSDO:developfrom
edwardlo12 wants to merge 11 commits intoIHTSDO:developfrom
Conversation
…uthentication token
…://github.com/MOHW-MedStandard-TW/snowstorm-private into Add-support-for-ValueSet.FilterOperator.EQUAL
QuyenLy87
force-pushed
the
develop
branch
2 times, most recently
from
47c3dfa to
0ce6bb4
Compare
QuyenLy87
force-pushed
the
develop
branch
2 times, most recently
from
91e0215 to
66c7a60
Compare
dmcgihtsdo
force-pushed
the
develop
branch
2 times, most recently
from
14551ab to
103a16b
Compare
dmcgihtsdo
force-pushed
the
develop
branch
4 times, most recently
from
99b6396 to
a4db4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes changes to the
collectConstraintsmethod in theFHIRValueSetServiceclass to update how filters are handled for generic code systems and ICD-10. The most notable changes include commenting out the block that explicitly disallowed property filters for ICD-10 and introducing support for theEQUALfilter operator for generic code systems.Updates to filter handling:
src/main/java/org/snomed/snowstorm/fhir/services/FHIRValueSetService.java: Commented out the block that disallowed property filters for ICD-10, making the code more flexible for future updates or extensions.src/main/java/org/snomed/snowstorm/fhir/services/FHIRValueSetService.java: Added support for theEQUALfilter operator for generic code systems, enabling inclusion constraints to handle equality comparisons.