Feat/diff two folders#10
Merged
Merged
Conversation
leavauchier
requested changes
Sep 25, 2025
leavauchier
left a comment
leavauchier
left a comment
Member
There was a problem hiding this comment.
Je ne sais pas trop où mettre ça mais je pense qu'il y a 2 trucs principaux qui manquent :
- le fait de vérifier que le fichier MNT secondaire existe bien avant de lancer les jobs GPAO (j'ai l'impression qu'il faudrait renvoyer une erreur si il manque des fichiers, vu qu'on suppose qu'on veut faire la diff pour l'ensemble des fichiers "primaires"
- l'info (dans l'aide du parser ou dans les docstrings des fonctions) qu'on se base sur le nom de fichier pour faire l'association entre les fichiers
Le reste, c'est plutôt de la mise en forme
leavauchier
requested changes
Sep 25, 2025
leavauchier
left a comment
leavauchier
left a comment
Member
There was a problem hiding this comment.
J'ai trouvé quelques autres occurences du lidarHD + un commentaire que tu n'as peut-être pas vu dans la génération de la commande docker
leavauchier
reviewed
Sep 29, 2025
leavauchier
approved these changes
Sep 29, 2025
| logging.debug(f"Create GPAO projects to compute difference maps with rge alti: {primary_dir}.") | ||
| if secondary_dir: | ||
| logging.debug( | ||
| f"Create GPAO projects to compute difference maps file by file between : \ |
Member
There was a problem hiding this comment.
un micro-pinaillage pour l'absence d'espace avant : en anglais
Suggested change
| f"Create GPAO projects to compute difference maps file by file between : \ | |
| f"Create GPAO projects to compute difference maps file by file between: \ |
leavauchier
requested changes
Sep 29, 2025
leavauchier
left a comment
leavauchier
left a comment
Member
There was a problem hiding this comment.
manque la mise à jour du changelog
leavauchier
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.