Add initial DiscordBot class and JDA dependencies#1
Open
TheKing-OfTime wants to merge 2 commits intomasterfrom
Open
Add initial DiscordBot class and JDA dependencies#1TheKing-OfTime wants to merge 2 commits intomasterfrom
TheKing-OfTime wants to merge 2 commits intomasterfrom
Conversation
ruskotwo
requested changes
Jul 4, 2023
| public static JDA bot; | ||
|
|
||
| public static void init() throws LoginException { | ||
|
|
Collaborator
There was a problem hiding this comment.
Что это за отступ? Что отделяет этот отступ? Начало метода от начала метода?
|
|
||
| @Override | ||
| public void onReady(@NotNull ReadyEvent event) { | ||
| Bukkit.getLogger().info("==Bot ready=="); |
Collaborator
There was a problem hiding this comment.
Не самый лучший текст. Ты тестил? Ты вообще знаешь, куда будет идти эта запись в консоль?
Лучше просто "Discord bot ready"
Collaborator
Author
There was a problem hiding this comment.
Как по мне нормально выглядит
| @@ -0,0 +1,53 @@ | |||
| package su.igc.discordauth; | |||
Collaborator
There was a problem hiding this comment.
Я не понимаю, ты вообще ни секунды не оглядываешь код, который ты публикуешь?
Сколько ты потратил на этот код? 14 секунд? Ты просто налепил как можно быстрее и закоммитил?
Тут должен быть отступ блять.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задача выполнена:
https://tracker.yandex.ru/DA-2