Conversation
|
49e05d2 to
acf791e
Compare
acf791e to
1ce897c
Compare
780e9a9 to
5eccd44
Compare
5eccd44 to
ecd4b8e
Compare
ecd4b8e to
e533077
Compare
9b3c8de to
99be76e
Compare
bebce77 to
9155563
Compare
2f55826 to
41e063c
Compare
d92474e to
233396f
Compare
7219d55 to
ec970d6
Compare
ec970d6 to
5a85291
Compare
| APP_RISK_API_ENDPOINT: 'https://go-risk-staging.northeurope.cloudapp.azure.com/api/v1/' | ||
| APP_TINY_API_KEY: 'dummy-api-key' | ||
| APP_TITLE: 'IFRC Go Test' | ||
| APP_TRANSLATION_API_ENDPOINT: 'https://cacheppuccino-alpha-1.ifrc-go.dev.togglecorp.com/' |
There was a problem hiding this comment.
Let's just add a dummy URL here.
There was a problem hiding this comment.
It is used to generate the typings
|
|
||
| console.info(duplicateStr); | ||
|
|
||
| throw `Error: found divirging migrations!`; |
| throw `Error: found divirging migrations!`; | ||
| } | ||
|
|
||
| console.info('All good! No divirging migrations!'); |
| "lint:js": "eslint src", | ||
| "lint:css": "stylelint \"./src/**/*.css\"", | ||
| "lint:translation": "pnpm translatte:lint", | ||
| "lint:translation": "pnpm translatte:lint && pnpm translatte:lint-migrations", |
There was a problem hiding this comment.
Why do we need a separate lint-migrations command?
There was a problem hiding this comment.
It checks for "divirging" migrations
| useRiskLazyRequest, | ||
| useRiskRequest, | ||
| useTranslationLazyRequest, | ||
| // useTranslationRequest, |
There was a problem hiding this comment.
Let's also define and export useTranslationRequest?
There was a problem hiding this comment.
It will be unused and knip will throw an error
| const defaultHeaders: HeadersInit = { | ||
| Authorization: token ? `Token ${token}` : '', | ||
| }; | ||
| // FIXME: only inject on go apis |
| return serverStrings; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
Do we need this commented out function?
| import pushMigrationsToIfrc from './commands/pushMigrationsToIfrc'; | ||
| import pushStringsFromExcelToIfrc from './commands/pushStringsFromExcelToIfrc'; | ||
| import lintMigrations from './commands/lintMigrations'; | ||
| import pushMigrationsToGo from './commands/pushMigrationsToGo'; |
There was a problem hiding this comment.
What is the difference between:
- pushMigrationsToIfrc
- pushMigrationsToGo
- pushStringsFromExcelToIfrc
There was a problem hiding this comment.
pushMigrationsToIfrc pushes migrations to IFRC Translation service
pushMigrationsToGo pushes migrations to GO API server
pushStringsFromExcelToIfrc pushes strings in excel to the IFRC translation service
| ) | ||
| .command( | ||
| 'lint-migrations <MIGRATION_DIR_PATH>', | ||
| 'Lint migration files for divirging migrations', |
| import { resolveUrl } from "../utils"; | ||
|
|
||
| // FIXME: get this from params | ||
| const applicationId = 18; |
There was a problem hiding this comment.
We should also add a FIXME to get params for "supported lanaguages"
Changes