Track document downloads#2776
Open
szabozoltan69 wants to merge 5 commits into
Open
Conversation
susilnem
requested changes
Jul 9, 2026
susilnem
left a comment
susilnem
left a comment
Member
There was a problem hiding this comment.
Overall, it looks good to me. Just some queries.
Member
There was a problem hiding this comment.
Are we planning to run this Script manually?
Contributor
Author
There was a problem hiding this comment.
No, a cronjob setting will run it in a recurring time.
| choices=DocumentType.choices, | ||
| ) | ||
| # PK of the source record – nullable for purely external documents | ||
| object_id = models.PositiveIntegerField( |
Member
There was a problem hiding this comment.
How do we check/verify this field?
Contributor
Author
There was a problem hiding this comment.
Not clear what you ask.
Member
There was a problem hiding this comment.
Just a simple check to see whether the object_id exists in our system or not.
Contributor
Author
There was a problem hiding this comment.
This object_id can point to different systems. So it can be a duplicate one. Not clear yet the existence check.
Contributor
Author
|
Thanksl, @susilnem , for the thorougful review and comments! |
szabozoltan69
force-pushed
the
feature/doc-download-tracking
branch
from
1a5047e to
f295f69
Compare
szabozoltan69
force-pushed
the
feature/doc-download-tracking
branch
from
4f94975 to
d763b19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #2065 and to IFRCGo/go-web-app#750