Refactor: improve overall consistency#10
Merged
Conversation
- readyz always reports ready; servable state is exposed as `ready` on /status - imports fully replace cached strings in one transaction - normalize lang query param to lowercase - fail fast on invalid or missing configuration - enable WAL; set pragmas via Exec so both sqlite drivers behave the same - add ETag/If-None-Match caching on /strings; expose ETag via CORS - inject build version via ldflags into openapi and /status - record last_pull on unchanged pulls too - drop BaseContext so shutdown drains in-flight requests - derive healthcheck URL safely from LISTEN_ADDR - reject non-positive durations in config - align INITIAL_PULL_DEADLINE default with docs (45s) - document 304 response in openapi schema; 500 where applicable - fix log-before-error in pull; remove dead code and nil-guards - add table-driven tests for parser, db, handlers, config, sync - add go test step to CI; pass VERSION build-arg to docker
frozenhelium
force-pushed
the
fix/consistency-improvements
branch
from
88af300 to
a5de165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.