Open
Conversation
Included the 3 new SVG's for Nz,Eng and Ned for points table
varun10sudhir
requested changes
Oct 10, 2023
Collaborator
varun10sudhir
left a comment
varun10sudhir
left a comment
There was a problem hiding this comment.
The flags are not of equal size and are not aligned properly.
Kindly fix that
Aligned with other flags
Alinged flags
Author
|
Kindly check now about the same , changes have been made. |
varun10sudhir
requested changes
Oct 11, 2023
Collaborator
varun10sudhir
left a comment
varun10sudhir
left a comment
There was a problem hiding this comment.
- New Zealand flag is incorrect
- Flags are still not fully aligned
Also , can u try increasing the size of all the flags?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Added SVG for Eng, Ned and Nz and also changed index.html to include the svg's so that points table could have correct flags in the name of country".