Conversation
031221d to
e7d2378
Compare
markfuge
left a comment
There was a problem hiding this comment.
In general, this is good @g-braeunlich
I think one improvement could be to have a concrete example at the end where we mention why and under what conditions someone would use certain constraints over another. I think this information is already clear in the documentation you made, but sometimes readers appreciate having a concrete use case and example where they can understand it in context.
This is something that I think @arthurdrake1 could provide or help you with. @arthurdrake1 do you think we could use the Beams2D example to show how and why we would use the difference constraint classes, maybe added as a section at the bottom labeld "Example" or something like this?
|
@markfuge, thanks for the heads up. I will look at the commits @g-braeunlich made and work on the Beams2D example today. |
|
@markfuge let me know if this is the type of thing you were thinking of. If so we can have @g-braeunlich include it where it's most appropriate. Beams2D ExampleHere, we provide a concrete example for the Beams2D problem that illustrates when to use certain constraints over others.
|
arthurdrake1
left a comment
There was a problem hiding this comment.
Per request I have also reviewed the changes and approve these additions to the documentation.
|
@g-braeunlich @markfuge and I discussed the above changes that I suggested and think they're good to go for incorporating into this PR. You can go ahead and include my example and close when you're ready. |
Description
Add docs about constraints.
Fixes #223
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .Reviewer Checklist: