Feature/update bundle to symfony 7#38
Feature/update bundle to symfony 7#38kurt-junker wants to merge 5 commits intoIDCI-Consulting:masterfrom
Conversation
Do not support symfony < 6.4 Support PHP >= 8.2
konandrum
left a comment
konandrum
left a comment
There was a problem hiding this comment.
Thanks for this great job, some changes needed
| public function onSymfonyComponentSecurityHttpEventLogoutEvent(LogoutEvent $event): void | ||
| { | ||
| if (null === $event->getToken() || null === $event->getToken()->getUser()) { | ||
| if (null === $event->getToken()?->getUser()) { |
There was a problem hiding this comment.
Not a good idea to use the null safe operator (uncompatible with < php8)
There was a problem hiding this comment.
hmmm Symfony 6.4 requires >= PHP 8.1
composer.json
Outdated
| "symfony/routing": "^5.3|^6.0", | ||
| "symfony/security-bundle": "^5.3|^6.0", | ||
| "symfony/http-foundation": "^5.3|^6.0", | ||
| "php": ">=8.2", |
There was a problem hiding this comment.
https://symfony.com/releases/6.4 => requirement php8.1.0 or higher
|
If you wish to add unit tests, will accept contributions with pleasure ! Thanks |
downgrading phpunit to 10.5
Hi @konandrum , I will create a new issue for the Unit Tests and write them in the next few days. Have a nice day :) |
| * @var string use to identify the "private"" way to call the auth server | ||
| */ | ||
| const MODE_PRIVATE = 'private'; | ||
| private const MODE_PRIVATE = 'private'; |
There was a problem hiding this comment.
| "symfony/stopwatch": "^6.4|^7.0", | ||
| "symfony/twig-bundle": "^6.4|^7.0", | ||
| "symfony/validator": "^6.4|^7.0", | ||
| "symfony/yaml": "^6.4|^7.0" |
There was a problem hiding this comment.
Symfony 5.4 is still officially supported and for a while. I think using a BC Layer is not too expensive here. I have no idea what @konandrum thinks about this...
| @@ -12,14 +12,14 @@ class ExceptionListener | |||
| /** | |||
| * @var UrlGeneratorInterface | |||
| */ | |||
3 participants
Hey @konandrum and @BeBlood
can you please check the Update of Symfony Components so we can use your Bundle with the LTS and Symfony 7.0
Thanks a lot.
PS: It would be nice to know how you handle Unit Tests? I didn't find any tests. If you prefer unit/integration tests please let me know and I will do it as soon as possible.