-
Notifications
You must be signed in to change notification settings - Fork 19
Adding dplasma CI as tester for parsec #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ac3e117 to
2124e44
Compare
|
I'm hitting an error where dplasma can't find a header from parsec. The parsec build isn't installing it: |
|
IT's an auto-generated header from the |
|
I had a look at the cmake config, and I think I see where it would need to be added. I can create a patchfile to include in this PR (just for testing), and if that's all that's required, we can make the change in the dplasma repo. Sound good? Edit: I forgot which repo this was in, so no patch is needed. I just added something that results in the apply.h being installed. |
|
This feature is already finding issues, great :D |
86fa51b to
1a01c3c
Compare
|
I also found a problem in the CMakeLists.txt for DPLASMA where MPIEXEC_NUMPROC_FLAGS was used instead of MPIEXEC_NUMPROC_FLAG (resulting in a failure to launch the mpi job). Now it looks like the only errors are due to "suspicious" solutions. |
|
Found another problem where dplasma can't find HIP if using an external parsec because the default rocm directory /opt/rocm isn't added to All tests are now running, and the only remaining problems are in incorrect tester results or tester segfaults. |
|
f58ef5a to
a84db79
Compare
62d383d to
13adde3
Compare
Need this PR for testing, do not merge.This adds a github workflow yaml in order to test parsec via dplasma. The YAML comes from the CI for dplasma with slight changes. Basically, from the checked-out parsec source, we create a clone of dplasma and execute the CI test of dplasma from that subdirectory. In order to use the newest sources of parsec instead of the dplasma submodule, we remove the parsec subdirectory in dplasma and replace it with a symlink to the parent directory.
@abouteiller Is this what you had in mind?