Draft
Conversation
Between compression and binary rep, this seems to save ~50% storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
Still toying around a bit here. npz seems to save ~50% storage when I compressed some of the existing data I have around.
I initially I thought we would add this data to the overall report, but it feels a bit awkward given its internal structure, so I left it in its own file for now and let you make that decision on how to integrate it.
I think this is actually also a nice time to upgrade the volume samples in the final outputs. They can be read of the per iteration files, but it's a bit inconvenient.
Will also create a pressure report unless you have other plans.