Skip to content

Drop dict_to_string #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srmnitc merged 1 commit into from
Mar 10, 2026
+1 −9
Merged

Drop dict_to_string #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions calphy/composition_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,6 @@ def __init__(self, calc):
self.mappingdict = None
self.prepare_mappings()

def dict_to_string(self, inputdict):
strlst = []
for key, val in inputdict.items():
strlst.append(str(key))
strlst.append(str(val))
return "".join(strlst)

@property
def entropy_contribution(self):
"""
Expand Down
3 changes: 1 addition & 2 deletions calphy/input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,7 @@ def _validate_all(self) -> "Input":
)
if not (natoms1 == natoms2):
raise ValueError(
f"Input and output number of atoms are not conserved! Input {self.dict_to_string(self.input_chemical_composition)}, output {self.dict_to_string(self.output_chemical_composition)}, total atoms in structure {structure.natoms}"
)
f"Input and output number of atoms are not conserved! Input {self.composition_scaling._input_chemical_composition}, output {self.composition_scaling.output_chemical_composition}, total atoms in structure {len(structure)}")
return self

def fix_paths(self, potlist):
Expand Down
Loading