Skip to content

fix: Fix LoadCSV fallback crash when indirect_read=True #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoavkatz wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −4
Open

fix: Fix LoadCSV fallback crash when indirect_read=True #1967

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5668cd9
fix: Security fix for CWE-95 (Eval Injection) in _get_torch_dtype()
yoavkatz Apr 21, 2026
ab6b9b2
fix: Fix LoadCSV fallback crash when indirect_read=True
yoavkatz May 18, 2026
aec6ef0
Merge branch 'main' into fix/loadcsv-indirect-read-fallback
yoavkatz May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/unitxt/loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,8 @@ def split_generator(self, split: str) -> Generator:
except ValueError:
import fsspec

with fsspec.open(file, mode="rt") as file:
dataframe = self.read_dataframe(file)
with fsspec.open(file, mode="rt") as f:
dataframe = self.read_dataframe(f)
break
except Exception as e:
logger.warning(f"Attempt load {attempt + 1} failed: {e}")
Expand Down Expand Up @@ -539,8 +539,7 @@ def read_dataframe(self, file) -> pd.DataFrame:
if self.column_names is not None:
args["names"] = self.column_names
args["header"] = None # Don't use first row as header
if self.indirect_read:
# Open the URL with urllib first to mitigate HTTP errors that sometime happen with the internal pandas implementation
if self.indirect_read and isinstance(file, str):
from urllib import request

with request.urlopen(file) as response:
Expand Down
Loading