refactor: remove prepare support#906
Merged
Merged
Conversation
The --prepare flag and related code were never fully implemented: openai and mistralrs backends had todo!()/error stubs, and the spnl backend only returned "prepared" for non-streaming. Remove the flag, GenerateOptions.prepare field, backend guards, tokenize_prepare FFI function and its helpers, and the CLI docs entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--prepareCLI flag andGenerateOptions.preparefield — never fully implemented across backendstokenize_prepareFFI function and its helper functions (extract_parts,extract_up_to_plus,encode_nonplus_part,encode_plus_part, standalonepad)Test plan
cargo checkpassescargo test— all 33 tests passcargo clippywith CI feature flags — zero warnings🤖 Generated with Claude Code