feat(local): add model pool unload to release GPU memory#903
Merged
Conversation
When running multiple models sequentially (e.g. multi-model benchmarks), previously loaded models remained in VRAM causing OOM errors. Adds ModelPool::unload_all() and exposes it as spnl::model_pool::unload_all() so callers can free GPU memory between model runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelPool::unload_all()to clear all cached models and release GPU memoryspnl::model_pool::unload_all()(behindlocalfeature gate)Test plan
bench pic --full(multi-model sweep) — verify models unload between runs and no OOMcargo check --features bench,metal🤖 Generated with Claude Code