feat(cli): add spnl bench subcommands#878
Merged
Merged
Conversation
starpit
force-pushed
the
feat/bench-cli
branch
from
f9ede39 to
8021b4b
Compare
…elease binaries
Move all benchmarks from spnl/benches/ (Criterion dev harness) into
cli/src/bench/ as proper CLI subcommands behind a `bench` feature flag.
Benchmarks are now runnable from prebuilt release binaries via
`spnl bench {haystack,niah,ruler,ragcsv}` with clap args replacing
env-var configuration. Criterion is used programmatically for timing
stats and baseline comparisons.
- Add cli `bench` feature with criterion, tokenizers, and other deps
- Port haystack, niah, ruler (Criterion-based) and ragcsv (standalone)
- Extract shared utilities: quantiles, progress bars, essay fetching
- Remove spnl/benches/ entirely (code, docs, and historical data)
- Drop inner_outer and mt_rag benchmarks
- Enable bench feature in release-cli.yml and core.yml CI workflows
- Fix clippy warnings inherited from original bench code
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
starpit
force-pushed
the
feat/bench-cli
branch
from
8021b4b to
cddd06f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spnl/benches/intocli/src/bench/asspnl bench {haystack,niah,ruler,ragcsv}subcommands behind abenchfeature flagspnl/benches/entirely (code, docs, historical data) along with inner_outer and mt_rag benchmarksbenchfeature in release-cli.yml and core.yml CI workflowsUsage
Test plan
cargo check -p spnl-cli --features benchcompiles cleancargo check -p spnl-cli(without bench) compiles cleancargo check -p spnlcompiles cleancargo clippy -p spnl-cli --features bench --no-deps -- -D warningspasses🤖 Generated with Claude Code