Skip to content

Conversation

@bbellamgari
Copy link
Contributor

@bbellamgari bbellamgari commented Nov 28, 2025

PR summary

This PR includes changes for role_template_references changes for policy template creation.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Currently we do not support role_template_references in policy templates. With this new behaviour, we are adding that functionality

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

https://github.ibm.com/IAM/AM-issues/issues/4045

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2025

CLA assistant check
All committers have signed the CLA.

@bbellamgari bbellamgari changed the title Updated role template references changes and test cases feat(IAM Policy Management): Updated role template references changes and test cases Nov 29, 2025
@pyrooka pyrooka self-requested a review December 8, 2025 10:47
@swcolley
Copy link
Contributor

Code looks good, see comment on go-sdk-pr:
IBM/platform-services-go-sdk#418 (review)

Also, you need to do CLA: #319 (comment)
Not sure why one is showing completed but the other is not. Also not sure why there are two commit authors.

@bbellamgari bbellamgari force-pushed the gen_sdk_role_template_references branch 4 times, most recently from 12b721c to 63454eb Compare December 10, 2025 07:06
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
@bbellamgari bbellamgari force-pushed the gen_sdk_role_template_references branch from 63454eb to 0afee84 Compare December 10, 2025 07:13
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbellamgari
Copy link
Contributor Author

$ jest test/integration/iam-policy-management.v1.test.js 
npm warn Unknown user config "always-auth" (//na.artifactory.swg-devops.com:443/artifactory/api/npm/iam-npm-local/:always-auth). This will stop working in the next major version of npm.
npm warn Unknown user config "always-auth" (//na.artifactory.swg-devops.com/artifactory/api/npm/iam-npm-remote/:always-auth). This will stop working in the next major version of npm.
 PASS  test/integration/iam-policy-management.v1.test.js (58.352 s)
  ● Console

    console.log
      Retrieved a total of 20 items(s) with pagination.

      at Object.log (test/integration/iam-policy-management.v1.test.js:1839:15)

    console.log
      Retrieved a total of 2 items(s) with pagination.

      at Object.log (test/integration/iam-policy-management.v1.test.js:1902:15)

-----------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                                                                                                  
-----------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
All files              |   77.58 |    58.16 |   84.77 |   78.79 |                                                                                                                                                                                    
 iam-policy-management |   77.42 |    58.16 |   84.71 |   78.64 |                                                                                                                                                                                    
  v1.ts                |   77.42 |    58.16 |   84.71 |   78.64 | ...-8528,8556-8563,8571,8579-8597,8605-8610,8638-8645,8653,8661-8679,8687-8692,8720-8727,8735,8743-8761,8769-8774,8803,8826,8885,8908,8912,8919,8966-8973,8981,8989-9007,9015-9020 
 lib                   |     100 |      100 |     100 |     100 |                                                                                                                                                                                    
  common.ts            |     100 |      100 |     100 |     100 |                                                                                                                                                                                    
-----------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Test Suites: 1 passed, 1 total
Tests:       77 passed, 77 total
Snapshots:   0 total
Time:        58.512 s
Ran all test suites matching /test\/integration\/iam-policy-management.v1.test.js/i.
-----------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                                                                                                  
-----------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
All files              |    78.2 |    57.95 |   85.59 |   79.65 |                                                                                                                                                                                    
 iam-policy-management |   78.05 |    57.95 |   85.53 |    79.5 |                                                                                                                                                                                    
  v1.ts                |   78.05 |    57.95 |   85.53 |    79.5 | ...-8597,8605-8610,8638-8645,8653,8661-8679,8687-8692,8720-8727,8735,8743-8761,8769-8774,8803,8826,8830,8837,8851-8856,8885,8908,8912,8919,8933-8938,8967,8990,8994,9001,9015-9020 
 lib                   |     100 |      100 |     100 |     100 |                                                                                                                                                                                    
  common.ts            |     100 |      100 |     100 |     100 |                                                                                                                                                                                    
-----------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Test Suites: 1 passed, 1 total
Tests:       66 passed, 66 total
Snapshots:   0 total
Time:        44.385 s, estimated 48 s
Ran all test suites matching /examples\/iam-policy-management.v1.test.js/i.

@bbellamgari bbellamgari merged commit 9aad590 into main Dec 10, 2025
12 checks passed
@bbellamgari bbellamgari deleted the gen_sdk_role_template_references branch December 10, 2025 17:05
ibm-devx-sdk pushed a commit that referenced this pull request Dec 10, 2025
# [0.80.0](v0.79.1...v0.80.0) (2025-12-10)

### Features

* **IAM Policy Management:** Updated role template references changes and test cases ([#319](#319)) ([9aad590](9aad590))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.80.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants