Move VCS initialization to during reconcile#123
Open
Conversation
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
HonakerM
force-pushed
the
fix_premature_vcs_creation
branch
from
1a07410 to
b98e129
Compare
gabe-l-hart
previously approved these changes
Oct 2, 2024
Collaborator
gabe-l-hart
left a comment
gabe-l-hart
left a comment
There was a problem hiding this comment.
Looks good, thanks Casey!
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Supports #?
Related PRs
This PR is not dependent on any other PR
What this PR does / why we need it
This PR fixes a bug which would cause reconciliation to unceremoniously fail when another process was using the git directory. These are normally caught by
safe_reconcilebut we have oneVCScall during__init__()that wasn't being caught. This PR moves that VCS call to happen duringreconcileSpecial notes for your reviewer
If applicable**
What gif most accurately describes how I feel towards this PR?