Conversation
…lear new clippy warnings Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
Signed-off-by: declark1 <44146800+declark1@users.noreply.github.com>
declark1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new constructor methods to
MockServerto specify the server type more explicitly:MockServer::new_http()andMockServer::new_grpc().Previously, the
grpc()builder method was used to set the server type to gRPC, e.g.MockServer::new().grpc(), which is a bit weird in this case. On a couple of occasions, I forgot to set.grpc()for gRPC mock servers, resulting in improper handling.MockServer::new()is unchanged and still creates a HTTP mock server. Thegrpc()builder method has been deprecated in favor ofMockServer::new_grpc().This also prepares version
0.3.0and drops the "alpha" suffix from the version.0.*will be considered alpha.Closes #52