Canonicalize headers when creating a HeaderMatcher.#50
Merged
Conversation
bIgBV
force-pushed
the
canonicalize-headers
branch
from
baa407a to
a62c50b
Compare
Contributor
|
Thanks @bIgBV. Can you clear the clippy warnings and sign your commits to pass the DCO check? |
bIgBV
force-pushed
the
canonicalize-headers
branch
from
86e26fe to
3473873
Compare
Contributor
Author
|
@declark1 latest commit should be good to go. I'm curious why the DCO check is still failing even though the commit messages have the signed-off-by footer. |
Contributor
@bIgBV hmm, it looks like an email address discrepancy; the check was expecting commit author email @microsoft.com but the sign-off is showing @gmail.com. |
added 2 commits
April 23, 2025 13:33
The current header matching behavior is case sensitive and requires clients to be aware of this behavior when setting up tests. This commit ensures that header names and values are canonicalized when a matcher is created inline with RC2616 Signed-off-by: Bhargav Voleti <bhargav.voleti93@gmail.com> Signed-off-by: Bhargav Voleti <bvoleti@microsoft.com>
Signed-off-by: Bhargav Voleti <bhargav.voleti93@gmail.com> Signed-off-by: Bhargav Voleti <bvoleti@microsoft.com>
bIgBV
force-pushed
the
canonicalize-headers
branch
from
3473873 to
eaa23d1
Compare
Contributor
Author
|
Ah, fair enough. I updated the history to align the footer. |
declark1
approved these changes
Apr 23, 2025
Contributor
declark1
left a comment
declark1
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current header matching behavior is case sensitive and requires clients to be aware of this behavior when setting up tests. This commit ensures that header names and values are canonicalized when a matcher is created inline with RC2616
Addresses #49