Conversation
mirosval
force-pushed
the
mockserver-send
branch
from
c99057e to
81a5a8d
Compare
Contributor
|
Hey, thanks for the PR (and the issue)! |
Contributor
|
@mirosval would you mind rebasing your branch and running |
mirosval
force-pushed
the
mockserver-send
branch
from
81a5a8d to
aefcbc1
Compare
With custom test runners, it's necessary to be able to use MockServer in a threaded setting, which is not possible as it is not `Send`. It's not `Send`, because it's using `OnceCell` which is not `Send` and it's using the `ThreadRng` which is also not `Send`. This PR replaces these with their equivalent versions that are `Send`. Additionally it adds a small test ensuring that `MockServer` remains `Send` in the future. Signed-off-by: Miroslav Zoricak <1315417+mirosval@users.noreply.github.com>
mirosval
force-pushed
the
mockserver-send
branch
from
aefcbc1 to
bb91c4f
Compare
Contributor
Author
|
@declark1 ran
You're not the only one, httpmock's server also isn't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With custom test runners, it's necessary to be able to use MockServer in a threaded setting, which is not possible as it is not
Send. It's notSend, because it's usingOnceCellwhich is notSendand it's using theThreadRngwhich is also notSend.This PR replaces these with their equivalent versions that are
Send. Additionally it adds a small test ensuring thatMockServerremainsSendin the future.Fixes #42