fix(server): return 404 when deleting non-existent server #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction Signed-off-by: Duarte Martinho <dmartinho@ibm.com>
Update test_delete_server_endpoint to mock get_server which is now called before delete_server to verify server existence. Add test_delete_server_not_found to verify that attempting to delete a non-existent server returns HTTP 404 instead of 400. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
requested review from
kevalmahajan and
madhav165
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_server()firstRelated
Changes
get_server()call beforedelete_server()to validate server existenceRoot Cause
The
delete_serverservice method has a broadexcept Exceptionhandler that catchesServerNotFoundErrorand converts it to a genericServerError, resulting in HTTP 400 instead of 404.Solution
This fix follows the same pattern used by
delete_gateway(line 3874 in main.py) - call the getter first to trigger the proper 404 response.A more comprehensive refactor of the service exception handling is tracked in #1591.