Added password_min_length: settings.password_min_length to the template context for the change-password page #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nayana-R-Gowda
requested review from
kevalmahajan and
madhav165
as code owners
rakdutta
requested changes
Dec 10, 2025
Collaborator
rakdutta
left a comment
rakdutta
left a comment
There was a problem hiding this comment.
The PR is not behaving as expected when PASSWORD_REQUIRE_UPPERCASE=True is enabled. During the server setup, the default admin@example.com user is still being created even though the default password does not contain any uppercase character, which violates the configured password policy. This indicates that the uppercase validation is not being enforced correctly at the time of default user creation.
…te context for the change-password page Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Signed-off-by: NAYANAR <nayana.r5@ibm.com>
…IRE_MIN_LENGTH is false Signed-off-by: NAYANAR <nayana.r5@ibm.com>
…me of default user creation Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Signed-off-by: NAYANAR <nayana.r5@ibm.com>
Nayana-R-Gowda
force-pushed
the
change-password-policy
branch
from
cc5327e to
6b09aa8
Compare
rakdutta
approved these changes
Dec 11, 2025
Collaborator
rakdutta
left a comment
rakdutta
left a comment
There was a problem hiding this comment.
Tested the PR by modifying the following environment variables with all possible value combinations, and everything is working as expected.
Therefore, the PR is ready to be merged.
PASSWORD_MIN_LENGTHPASSWORD_REQUIRE_UPPERCASEPASSWORD_REQUIRE_LOWERCASEPASSWORD_REQUIRE_NUMBERSPASSWORD_REQUIRE_SPECIAL
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANAR nayana.r5@ibm.com
🐛 Bug-fix PR
💡 Fix Description
How did you solve it? Key design points.
Implement password-policy visibility toggle in Change Password screen based on environment variables
🧪 Verification
make lintmake test📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)