Fix/1545 inactive resource 404 #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include inactive resources when fetching resource details for editing. This fixes the 404 error that occurred when clicking Edit on an inactive resource in the admin UI. Closes IBM#1545 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
fix/1545-inactive-resource-404
branch
from
862a5a5 to
4c6467e
Compare
crivetimihai
approved these changes
Dec 13, 2025
Member
There was a problem hiding this comment.
Thanks for the contribution! I've rebased and simplified this PR.
Changes made:
- Removed unrelated commits (uv installation support, OAuth logging/depth handling)
- Fixed a bug where resource_id type was changed from str to int (would break UUID lookups)
The fix: The admin endpoint for fetching resource details now passes include_inactive=True to the service, allowing inactive resources to be edited. This is cleaner than adding a query parameter since admins should always be able to edit any resource regardless of active/inactive status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fix 404 when editing inactive resources #1549
Add include_inactive query parameter support to allow editing
inactive resources in admin UI with ?include_inactive=true