Fix: Propagate app_user_email when a global context already exists #1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliaMManolov
force-pushed
the
fix_app_user_email_propagation
branch
from
2022d6a to
60ed09d
Compare
Signed-off-by: Ilia Manolov <iliamanolov@outlook.com>
IliaMManolov
force-pushed
the
fix_app_user_email_propagation
branch
from
60ed09d to
f8d041e
Compare
Contributor
Author
|
Hi there, I just noticed that 3 of the CI checks failed due to an attempted write to the IBM org package. I presume it's because I don't have some permissions? I hope the PR will still be considered regardless. |
Member
|
Closes #1550 |
crivetimihai
added a commit
that referenced
this pull request
Dec 12, 2025
When invoke_tool receives an existing plugin_global_context from middleware, the user email was not being propagated to the global context. This caused plugins to receive user: null in their GlobalContext. This fix ensures the user email is always propagated to the global context when available, enabling security plugins to properly track which user made each request. Closes #1550 Supersedes #1551 Co-authored-by: Ilia Manolov <iliamanolov@outlook.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Member
|
Hi @IliaMManolov, thank you for identifying this issue and submitting the fix! I've created #1590 which supersedes this PR. The reason is that I couldn't push to your fork (maintainer edits not enabled), and I also noticed a small bug in the condition: # Original (checks gateway_id):
if gateway_id and isinstance(app_user_email, str):
# Fixed (checks app_user_email):
if app_user_email and isinstance(app_user_email, str):
The user email should be propagated regardless of whether a gateway_id exists.
You're credited as co-author on the new PR. Thanks again for the contribution! |
crivetimihai
added a commit
that referenced
this pull request
Dec 12, 2025
When invoke_tool receives an existing plugin_global_context from middleware, the user email was not being propagated to the global context. This caused plugins to receive user: null in their GlobalContext. This fix ensures the user email is always propagated to the global context when available, enabling security plugins to properly track which user made each request. Closes #1550 Supersedes #1551 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Ilia Manolov <iliamanolov@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
Fixes the issue outlined here.
🔁 Reproduction Steps
See the issue above.
🐞 Root Cause
See the issue above.
💡 Fix Description
Added the two lines as mentioned in the issue above.
🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)Screenshots: