Tools Telemetry Exporter plugin #1538
Conversation
barvhaim
force-pushed
the
plugin/tools_with_additional_telemetry
branch
from
c789de6 to
cca9d69
Compare
barvhaim
changed the title
araujof
left a comment
araujof
left a comment
There was a problem hiding this comment.
@barvhaim thanks for the PR. My recommendation is to add OpenTelemetry tracers for ContextForge hooks directly in the plugin framework, rather than implementing them inside individual plugins. A few reasons:
- A tracer implemented as a plugin hook only has visibility into the context passed to that specific plugin — meaning the tool name would appear as the telemetry plugin itself. It also limits your ability to enforce global context propagation or observe other plugins’ execution. Plugins shouldn’t need awareness of other plugins to function correctly.
- Relying on plugin priority to ensure this plugin runs first is unreliable. Other plugins may also define the lowest priority, creating ordering conflicts.
- Implementing tracing within the framework is more robust. The framework is already trusted, and the plugin manager has full control and mediation over plugin execution. This makes it possible to implement complete, consistent tracing with lower risk of circumvention or misconfiguration.
I suggest we close this PR and coordinate with @terylt to address any observability gaps directly in the Plugin Framework.
|
@araujof thanks for your response, let's discuss before closing, The current plugin is only adding to the existing tool invocation span additional information about the tool invocation for as sub-span for the "existing span" the input arguments from the pre-invoke and the output from the post-invoke Adding it as plugin was the fastest way I found to do so without changing the framework |
Add new plugin that exports comprehensive tool invocation telemetry to OpenTelemetry for observability and monitoring. Features: - Pre-invocation telemetry: request context, tool metadata, target MCP server details, and tool arguments - Post-invocation telemetry: request context, tool results (optional), and error status - Automatic payload truncation to respect size limits - Graceful degradation when OpenTelemetry is not available Configuration options: - export_full_payload: Export full tool results in post-invocation - max_payload_bytes_size: Maximum payload size before truncation The plugin is disabled by default and requires OpenTelemetry to be enabled on the gateway. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
plugin/tools_with_additional_telemetry
branch
from
e56d9de to
51bc251
Compare
crivetimihai
left a comment
crivetimihai
left a comment
There was a problem hiding this comment.
Thanks! Rebased and tested.
3 participants
🧱 New Plugin
Tools Telemetry Exporter
🚀 Summary
Export comprehensive tool invocation telemetry to OpenTelemetry
🧪 Checks
make lint pluginspassesmake testpasses