Skip to content

Refactor: eliminate code duplication and fix script syntax error #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor: eliminate code duplication and fix script syntax error #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4094728
Initial plan
Copilot Nov 9, 2025
44bdf48
Fix code quality issues: remove duplication, extract helpers, fix scr…
Copilot Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 21 additions & 108 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
maxSize: 50
};

// Application State
const state = {
image: null,
svgCode: null,
// Default state values
const DEFAULT_STATE = {
imageTransform: {
rotation: 0, // 0, 90, 180, 270
flipH: false,
Expand Down Expand Up @@ -77,9 +75,16 @@
}
};

// Save state to history
function saveStateToHistory() {
const stateCopy = JSON.parse(JSON.stringify({
// Application State
const state = {
image: null,
svgCode: null,
...JSON.parse(JSON.stringify(DEFAULT_STATE))
};

// Helper function to clone state for history management
function cloneState() {
return JSON.parse(JSON.stringify({
imageTransform: state.imageTransform,
imageFilters: state.imageFilters,
textOverlay: state.textOverlay,
Expand All @@ -95,6 +100,11 @@
shadow: state.shadow,
canvas: state.canvas
}));
}

// Save state to history
function saveStateToHistory() {
const stateCopy = cloneState();

history.past.push(stateCopy);
if (history.past.length > history.maxSize) {
Expand All @@ -108,22 +118,7 @@
function undo() {
if (history.past.length === 0) return;

const currentState = JSON.parse(JSON.stringify({
imageTransform: state.imageTransform,
imageFilters: state.imageFilters,
textOverlay: state.textOverlay,
windowOverlay: state.windowOverlay,
watermark: state.watermark,
gradient: state.gradient,
padding: state.padding,
scale: state.scale,
borderRadius: state.borderRadius,
showBorder: state.showBorder,
borderWidth: state.borderWidth,
borderColor: state.borderColor,
shadow: state.shadow,
canvas: state.canvas
}));
const currentState = cloneState();

history.future.push(currentState);
const previousState = history.past.pop();
Expand All @@ -138,22 +133,7 @@
function redo() {
if (history.future.length === 0) return;

const currentState = JSON.parse(JSON.stringify({
imageTransform: state.imageTransform,
imageFilters: state.imageFilters,
textOverlay: state.textOverlay,
windowOverlay: state.windowOverlay,
watermark: state.watermark,
gradient: state.gradient,
padding: state.padding,
scale: state.scale,
borderRadius: state.borderRadius,
showBorder: state.showBorder,
borderWidth: state.borderWidth,
borderColor: state.borderColor,
shadow: state.shadow,
canvas: state.canvas
}));
const currentState = cloneState();

history.past.push(currentState);
const nextState = history.future.pop();
Expand Down Expand Up @@ -1706,74 +1686,8 @@

// Reset Function
function resetToDefaults() {
// Reset state
state.imageTransform = {
rotation: 0,
flipH: false,
flipV: false
};
state.imageFilters = {
brightness: 100,
contrast: 100,
saturation: 100,
blur: 0,
grayscale: 0,
sepia: 0
};
state.textOverlay = {
enabled: false,
content: '',
size: 48,
font: 'Arial',
color: '#ffffff',
bold: false,
italic: false,
x: 0.5,
y: 0.5
};
state.windowOverlay = {
enabled: false,
style: 'macos',
title: 'Screenshot',
height: 40,
showControls: true
};
state.watermark = {
enabled: false,
text: '',
position: 'bottom-right',
size: 16,
opacity: 50,
color: '#ffffff'
};
state.exportSettings = {
format: 'png',
quality: 92
};
state.gradient = {
type: 'linear',
angle: 135,
colors: ['#667eea', '#764ba2'],
positions: [0, 100]
};
state.padding = 60;
state.scale = 100;
state.borderRadius = 12;
state.showBorder = false;
state.borderWidth = 2;
state.borderColor = '#ffffff';
state.shadow = {
blur: 40,
spread: 10,
opacity: 30,
x: 0,
y: 10,
color: '#000000'
};
state.canvas = {
width: 1200,
height: 675
};
// Reset state to defaults
Object.assign(state, JSON.parse(JSON.stringify(DEFAULT_STATE)));

// Update all UI elements
elements.brightness.value = 100;
Expand Down Expand Up @@ -1906,4 +1820,3 @@

// Start the application
init();
</script>
Loading