Skip to content

fix(backend): remove tcp try reconnect #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JavierRibaldelRio merged 1 commit into from
Jun 24, 2026
Merged

fix(backend): remove tcp try reconnect #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions backend/pkg/transport/network/tcp/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ func (client *Client) Dial() (net.Conn, error) {
client.logger.Error().Stack().Err(client.config.Context.Err()).Msg("canceled")
return nil, client.config.Context.Err()
}

// If reconnection is disabled, bail out immediately on any error
if !client.config.TryReconnect {
client.logger.Error().Stack().Err(err).Msg("failed with non-retryable error")
return nil, err
}
}

client.logger.Debug().Int("max", client.config.MaxConnectionRetries).Msg("max connection retries exceeded")
Expand Down
2 changes: 0 additions & 2 deletions backend/pkg/transport/network/tcp/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ type ClientConfig struct {

Context context.Context

TryReconnect bool
ConnectionBackoffFunction backoffFunction
MaxConnectionRetries int
}
Expand All @@ -34,7 +33,6 @@ func NewClientConfig(laddr net.Addr) ClientConfig {
},

Context: context.TODO(),
TryReconnect: true,
ConnectionBackoffFunction: NewExponentialBackoff(defaultBackoffMin, defaultBackoffExp, defaultBackoffMax),
MaxConnectionRetries: -1,
}
Expand Down
16 changes: 0 additions & 16 deletions backend/pkg/transport/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,11 @@ func (transport *Transport) HandleClient(config tcp.ClientConfig, remote string)
client := tcp.NewClient(remote, config, transport.logger)
clientLogger := transport.logger.With().Str("remoteAddress", remote).Logger()
defer clientLogger.Warn().Msg("abort connection")
hasConnected := false

for {
conn, err := client.Dial()
if err != nil {
clientLogger.Debug().Stack().Err(err).Msg("dial failed")
// Only return if reconnection is disabled
if !config.TryReconnect {
if hasConnected {
transport.SendFault()
}
transport.errChan <- err
return err
}

// For ErrTooManyRetries, we still want to continue retrying
// The client will reset its retry counter on the next Dial() call
Expand All @@ -81,8 +72,6 @@ func (transport *Transport) HandleClient(config tcp.ClientConfig, remote string)
continue
}

hasConnected = true

err = transport.handleTCPConn(conn)
if errors.Is(err, error(ErrTargetAlreadyConnected{})) {
clientLogger.Warn().Stack().Err(err).Msg("multiple connections for same target")
Expand All @@ -91,11 +80,6 @@ func (transport *Transport) HandleClient(config tcp.ClientConfig, remote string)
}
if err != nil {
clientLogger.Debug().Stack().Err(err).Msg("connection lost")
if !config.TryReconnect {
transport.SendFault()
transport.errChan <- err
return err
}

// Connection was lost, continue trying to reconnect
continue
Expand Down
Loading