Add proof of concept procedurally generated level#2
Open
kilo-code-bot[bot] wants to merge 3 commits intomainfrom
Open
Add proof of concept procedurally generated level#2kilo-code-bot[bot] wants to merge 3 commits intomainfrom
kilo-code-bot[bot] wants to merge 3 commits intomainfrom
Conversation
- Added a new POC game with a single testable level - Level uses BSP room generation with gems to collect and stairs to find - Includes slow mobs for light challenge but remains accessible - Modified STARTING_GAME to use POC for easy testing The level is designed to be: - Playable and winnable - Not too difficult - Have a clear objective (collect gems, reach stairs) - Include some enemies but remain accessible
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| } | ||
|
|
||
| export function findNextLevel(_i: number) { | ||
| return 'END'; |
Author
There was a problem hiding this comment.
CRITICAL: Returns string 'END' instead of Symbol END
In src/modules/levels.ts:66, the code checks if (i === END) where END is a Symbol. Returning the string 'END' will never match this comparison, causing the game to fail to detect end-of-level and likely cause a runtime error when trying to load level 'END'.
Suggested change
| return 'END'; | |
| import { END } from '../../modules/games'; | |
| // ... | |
| return END; |
Author
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (6 files)
Fix Link: Fix these issues in Kilo Cloud |
- Added 'The Entry Chamber' - a custom hand-crafted level - Features: Key/door mechanic, multiple rooms, gems, nuggets - Locked door requires finding the key (K) - Tutorial message explains mechanics - Level 2+ uses procedural generation Level Design: - Starting room with whip and gems - Multiple rooms to explore - Key hidden in a side room - Locked door blocks the stairs - Must collect key to reach exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STARTING_GAMEconstant to use POC for easy testingLevel Design
The POC level is designed to be:
Files Changed
src/data/poc/index.ts- New POC game modulesrc/data/proc-gen/index.ts- Added POC level to proc-gen levelssrc/modules/games.ts- Registered new POC gamesrc/constants/constants.ts- Changed STARTING_GAME to POCTesting
Run
npm startto launch the game - it will automatically start the POC level.Built for hypercubed by Kilo for Slack