-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/slashing #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/slashing #122
Conversation
…ansaction for each double-signing validator
…dded in readContracts array.
…ss proposer and validators
107f2b0 to
1489a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support the IBFT consensus, so no need to make updates there
| // initDoubleSigningTracker initializes double signing tracker | ||
| // | ||
| // (which is used for creating slashing evidence). | ||
| func (c *consensusRuntime) initDoubleSigningTracker(logger hcf.Logger, store *StakeStore) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the repo standards, new contracts should be added to the core-contracts repository, which is included here as a submodule. After that, use artifacts-gen to generate and import the artifacts for use in this repository.
| HydraStakingContractV1 = types.StringToAddress("0x1041") | ||
| // DefaultBurnContract is an address of eip1559 default proxy contract | ||
| DefaultBurnContract = types.StringToAddress("0x105") | ||
| DefaultBurnContract = types.StringToAddress("0x106") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't update the existing contracts' addresses as these contracts are already deployed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this somehow useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file didn’t exist previously, I’m not sure how it contributes to backward compatibility.
| } | ||
|
|
||
| // GetPendingSlashProofs retrieves executable slashing exit event proofs | ||
| func (c *consensusRuntime) GetPendingSlashProofs() ([]types.Proof, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unused?
|
Hello Team! Technical Partnership ProposalHydra Chain - Slashing Module Development SupportExecutive SummaryOur engineering team has been actively monitoring the Hydra-Chain/hydragon-node repository for the past 2-3 months. We've identified an opportunity to accelerate the development of critical infrastructure, specifically the Slashing Module (PR #122), which has been in review status with requested changes. Our ObservationRepository Analysis
Key FindingThe Slashing Module PR has been open with reviewer feedback requiring significant architectural changes:
What We Bring to the TableDeep Codebase FamiliarityOur developers have:
Immediate ValueWe can help complete the Slashing Module by:
Proposed EngagementPhase 1: PR #122 Completion (Slashing Module)
Phase 2: Ongoing Development Support
Why Partner With Us?
Technical CredentialsOur team has experience with:
Next Steps
ContactWe're ready to help accelerate Hydra Chain's development. Let's discuss how we can support your team in shipping the Slashing Module and beyond. www.ocena.in Let's build together. This proposal is based on our independent analysis of the public hydragon-node repository. We respect your team's architectural decisions and aim to complement your existing development efforts. |
This PR introduces a robust slashing module to the PolyBFT consensus engine. The new module detects validators who double-sign blocks and initiates slashing by creating and submitting system transactions to the slashing contract.