Separate translatable words to prep for translation#41
Separate translatable words to prep for translation#41jakobh7 wants to merge 2 commits intoHun-Spell-It:developfrom
Conversation
| @@ -83,4 +83,44 @@ export class DataService { | |||
| }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These methods will be updated over the weekend to actually implement reading from PO files
There was a problem hiding this comment.
@jakobh7 Nice, would the PO files stored at the frontend or have to make a request from RESTful API?
kobh7 Do we need to think about what default values for those strings are? Could be English for example or leave it blank?
There was a problem hiding this comment.
I think the PO files on the front end shouldn't have to make requests to the RESTful API. I was thinking the default values for the strings would be English, but that's just because that's the common language we're writing in currently.
pannapat
left a comment
pannapat
left a comment
There was a problem hiding this comment.
I just added a question related to the service part.
| @@ -83,4 +83,44 @@ export class DataService { | |||
| }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@jakobh7 Nice, would the PO files stored at the frontend or have to make a request from RESTful API?
kobh7 Do we need to think about what default values for those strings are? Could be English for example or leave it blank?
2 participants
This code has all translatable words separated out for ease of translation. Let me know if I've missed anything or I need to add anything