feat: HUMSIG-37: Enhancing ML backend connection experience #5546

niklub · 2024-03-06T20:18:27Z

PR fulfills these requirements

Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

Product design
Backend (Database)
Backend (API)
Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

Yes, and covered entirely by feature flag(s)
Yes, and covered partially by feature flag(s)
No
Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

e2e
integration
unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

feat: HUMSIG-37: Enhancing ML backend connection experience dm2#310

…ollow

updating tests

…roject setting

…abel-studio into dev/ml-backend-exp

netlify · 2024-03-06T20:18:41Z

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name	Link
🔨 Latest commit	`911c1e3`
🔍 Latest deploy log	https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65ef89c86726e50008798c10

netlify · 2024-03-06T20:18:43Z

✅ Deploy Preview for heartex-docs canceled.

Name	Link
🔨 Latest commit	`911c1e3`
🔍 Latest deploy log	https://app.netlify.com/sites/heartex-docs/deploys/65ef89c8812ac70008a3d717

codecov · 2024-03-06T20:29:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (40e174b) to head (911c1e3).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5546      +/-   ##
===========================================
- Coverage    75.77%   75.37%   -0.41%     
===========================================
  Files          157      157              
  Lines        13125    13249     +124     
===========================================
+ Hits          9946     9986      +40     
- Misses        3179     3263      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8192397383

web/apps/labelstudio/src/components/Form/Elements/Select/Select.js

web/apps/labelstudio/src/config/ApiConfig.js

bmartel · 2024-03-07T21:01:19Z

web/apps/labelstudio/src/components/Form/Elements/ToggleRight/ToggleRight.styl

@@ -0,0 +1,56 @@
+.toggle-right


@nicholasrq You mentioned SCSS is the way forward, how strongly are we taking that at this time with regards to new code? With Stylus having been long deprecated we are going to have to move all existing Stylus over to SCSS, and wanted to know if that is something we are trying to encourage in new PRs?

web/apps/labelstudio/src/assets/icons/index.js

web/apps/labelstudio/src/assets/icons/spark_grey.svg

web/apps/labelstudio/src/components/Form/Form.js

web/apps/labelstudio/src/pages/Settings/MachineLearningSettings/MachineLearningList.js

web/apps/labelstudio/src/pages/Settings/MachineLearningSettings/MachineLearningSettings.js

web/apps/labelstudio/src/pages/Settings/MachineLearningSettings/StartModelTraining.js

web/apps/labelstudio/src/pages/Settings/PredictionsSettings/PredictionsList.js

web/apps/labelstudio/src/pages/Settings/index.js

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8237179655

…ckend-exp

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8237277894

…ckend-exp

bmartel

Ran a formatter/linter on the other frontend files, pushed that up as well. Looks good overall now.

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8237418085

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8238405264

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8240219216

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8240697575

jombooth · 2024-03-12T21:12:43Z

label_studio/tasks/serializers.py

    def get_predictions(self, task):
-        project = task.project
-        if not project.show_collab_predictions:
-            return []
-        else:
-            for ml_backend in project.ml_backends.all():
-                ml_backend.predict_tasks([task])
-            return super().get_predictions(task)
+        """ """
+        predictions = task.get_predictions_for_prelabeling()
+        return PredictionSerializer(predictions, many=True, read_only=True, default=[], context=self.context).data
+
+    # def get_predictions(self, task):
+    #     project = task.project
+
+    #     if not project.show_collab_predictions:
+    #         return []
+    # else:
+    #     # for ml_backend in project.ml_backends.all():
+    #     #     ml_backend.predict_tasks([task])
+    #     return super().get_predictions(task)


Need to make sure we didn't break anything with this change, and remove commented out code

bmartel · 2024-03-12T21:30:39Z

label_studio/data_manager/actions/basic.py

        'title': 'Retrieve Predictions',
        'order': 90,
        'dialog': {
+            'modal_title': 'Retrieve Predictions',


modal_title -> title

bmartel · 2024-03-12T21:30:55Z

label_studio/data_manager/actions/predictions_to_annotations.py

        'dialog': {
-            'text': 'This action will create new annotations from predictions with the selected model version '
-            'for each selected task.',
+            'modal_title': 'Create Annotations From Predictions',


modal_title -> title

…5546)" This reverts commit b198728.

#5569) Revert "feat: HUMSIG-37: Enhancing ML backend connection experience (#5546)" This reverts commit b198728. Co-authored-by: nik <nik@heartex.net>

Mikhail Maluyk and others added 7 commits February 4, 2024 22:36

Updated implementation of the ML Backend experience. Docs & Test to f…

4ae5e6e

…ollow

Updating the experience a bit more based on the feedback. Plus

72da7a9

updating tests

minor updates on the experience

e6fc978

removing debug info, uncommenting bits

9b1f263

Merge branch 'develop' into dev/ml-backend-exp

bf134a6

fixing small issue to make it backward compatible with the previous p…

12a7227

…roject setting

Merge branch 'dev/ml-backend-exp' of https://github.com/heartexlabs/l…

8eec2cd

…abel-studio into dev/ml-backend-exp

github-actions bot added the title needs formatting label Mar 6, 2024

niklub force-pushed the fb-ml-backend-exp branch from 300824f to 4bbd435 Compare March 7, 2024 13:09

niklub changed the title ~~Fb ml backend exp~~ feat: HUMSIG-37: Enhancing ML backend connection experience Mar 7, 2024

github-actions bot added feat and removed title needs formatting labels Mar 7, 2024

nik added 3 commits March 7, 2024 17:00

Fix errors, code cleanup, fix ruff

9d314e7

Downgrade testing-library, reformat with linters

fb48fc7

Remove excessive calls in task api

9211b86

niklub force-pushed the fb-ml-backend-exp branch from 12f300c to 9211b86 Compare March 7, 2024 17:00

nik and others added 3 commits March 7, 2024 17:34

Fix frontend script

3b082f2

ci: Build frontend

a14857d

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8192397383

fmt

1379c5c

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/components/Form/Elements/Select/Select.js Outdated Show resolved Hide resolved

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/components/Form/Elements/Select/Select.js Outdated Show resolved Hide resolved

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/components/Form/Elements/Select/Select.js Outdated Show resolved Hide resolved

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/config/ApiConfig.js Outdated Show resolved Hide resolved

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/assets/icons/index.js Outdated Show resolved Hide resolved

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/assets/icons/spark_grey.svg Show resolved Hide resolved

bmartel reviewed Mar 7, 2024

View reviewed changes

web/apps/labelstudio/src/components/Form/Form.js Outdated Show resolved Hide resolved