Skip to content

Conversation

@venus-dv
Copy link
Collaborator

Improved overall responsiveness, cleaned up jsx files and made external css sheets.

Copy link
Owner

@Howllo Howllo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve this change since it breaks a lot of the fundamentals of the website. It make it far too responsive. The idea of the system was to people use screens less than 1080p.

What the changes does:
tooresponsive

What it should look like still:
whatitshouldlooklike

For 720p:
menu

For 1080p / 16:9:
normal

@venus-dv venus-dv requested a review from Howllo January 12, 2025 20:17
Copy link
Owner

@Howllo Howllo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design is still not strict. The feed should be only max and min of 650px. There should not be uneven padding at the top. They should be both be hard locked to around 20px-ish paddingTop. Responsive design doesn't mean stretchy design. Stretchy design usually breaks the UI styling like what it is doing currently. It you should be changing component out and replacing them with more mobile friendly ones based on break points.

image

@venus-dv venus-dv requested a review from Howllo January 12, 2025 23:53
Copy link
Owner

@Howllo Howllo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better than first time, but I gave you wrong information. The size of the feed is actually 600px. After reworking the post and post page I realized that it was actually 650.

It looks great, but few errors there are border radius on this post making it not line up. It needs to be zero radius. It also need line up the lines to be line like rest of the lines:
image

The FAB icon as a elevation:
image

The post icon should be on rightsidebar and on two end, justify end and align end. I think if that doesn't work you can also try marginTop auto.
image

This will make the overall design much better.
image

Since you already adjusting the navbar stuff. It would be nice also extend the nav buttons full length like this:
image

This would give it finishing touch. Overall, great execution so far.

@venus-dv venus-dv requested a review from Howllo January 13, 2025 01:58
Copy link
Owner

@Howllo Howllo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the Participate in discussion that is now too large;

image

vs

image

Also seems like the user profile is also missing lines:
image

vs

image

Optional (This might break the core of the website, so you don't have to do this):

In the current design the scroll bar is inside one of the grids (Middle grid that allows for y overflow):
image

The original design is suppose to have the scroll bar on the far left side, where you can scroll the everyone menu, but I think this is a core website that could break a lot of things. Once the other fixes are out you can try fix this, but you don't have to at all. It just design flaw in my original design. Reason I am stating this that it could take 30 minutes to fix or entire day.

@venus-dv venus-dv requested a review from Howllo January 13, 2025 02:31
Copy link
Owner

@Howllo Howllo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create post is not restricted to 600 px wide:

image

@venus-dv venus-dv requested a review from Howllo January 13, 2025 02:54
@Howllo Howllo merged commit af15ab6 into master Jan 13, 2025
1 check passed
@Howllo Howllo deleted the feature/responsive-design branch January 13, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants