Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary:
How It Works:
Metrics Middleware: A new MetricsMiddleware wraps the HTTP router. It captures the start time of every request and records:
http_requests_total (Counter): Labeled by method, route, and status.
http_request_duration_seconds (Histogram): Captures latency buckets for P99/P95 calculations.
Route Normalization: The middleware uses parameterized route names (e.g., /v1/r/{code}) rather than raw paths to prevent high-cardinality issues in Prometheus.
Docker Stack:
Prometheus: Configured to scrape host.docker.internal:8080/metrics every 5 seconds.
Grafana: Pre-provisioned to visualize the Prometheus data on port 3000.
Logging: Replaced standard fmt print statements with a global Zap logger configuration.
Additional Notes (optional):
Access: Grafana is available at http://localhost:3000 (default creds: admin/admin) when running docker compose up.
Trade-offs: Deferred OpenTelemetry (tracing) implementation as the current architecture is single-service and basic structured logging/metrics provide sufficient visibility for now.
Verification: Verified that the /metrics endpoint is correctly outputting Prometheus-formatted text with appropriate buckets.