Skip to content

Fix typos in implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OleksandrMizov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typos in implementation #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41e443
Fix typos in implementation
OleksandrMizov Jan 7, 2026
65e3613
Remove JSON.stringify
OleksandrMizov Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SchemaBased/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const schema = {
children: { array: 'string' },
parents: { father: '?string', mother: '?string' },
militaryVictories: 'counter',
campaigns: {
wars: {
object: { string: 'counter' },
},
};
Expand Down
12 changes: 8 additions & 4 deletions StateBased/8-pn-set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,24 +70,28 @@ class PNSet {
// Usage

console.log('Replica 0');
const set0 = new PNSet(0);
const set0 = new PNSet({id: 0});
set0.add('a');
set0.add('b');
set0.remove('a');
console.log({ id0: set0.value });
console.log(JSON.stringify({ id0: { added: set0.added, removed: set0.removed } }));
Copy link
Copy Markdown
Member

@belochub belochub Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be better to instead do

Suggested change
console.log(JSON.stringify({ id0: { added: set0.added, removed: set0.removed } }));
console.dir({ id0: { added: set0.added, removed: set0.removed } }, { depth: null });



console.log('Replica 1');
const set1 = new PNSet(1);
const set1 = new PNSet({id: 1});
set1.add('b');
set1.add('c');
set1.remove('b');
console.log({ id1: set1.value });
console.log(JSON.stringify({ id1: { added: set1.added, removed: set1.removed } }));


console.log('Sync');
set0.merge(set1);
set1.merge(set0);
console.log({ id0: { added: set0.added, removed: set0.removed } });
console.log({ id1: { added: set1.added, removed: set1.removed } });
console.log(JSON.stringify({ id0: { added: set0.added, removed: set0.removed } }));
console.log(JSON.stringify({ id1: { added: set1.added, removed: set1.removed } }));

console.log('Get value');
console.log({ id0: set0.value });
Expand Down