fix(ci): Profiling Tests (Weekly) workflow failing on main#548
Merged
Conversation
CMake configure was failing with "Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)" because the workflow installed apt build tools but never ran `conan install`. GTest is provided via Conan (gtest/1.14.0) per conanfile.py and required by find_package(GTest REQUIRED) in CMakeLists.txt. Switch to the canonical pattern used by _required.yml: - Use the .github/actions/install-build-deps composite action (installs clang-18, cmake, ninja, AND conan with detected profile) - Cache ~/.conan2 keyed on conanfile.py hash - Run `conan install` for Release before cmake configure - Pass -DCMAKE_TOOLCHAIN_FILE=build/conan-deps/conan_toolchain.cmake so find_package() locates GTest Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs Profiling Tests (Weekly) (run 25620831958, persistent across at least the last two weekly runs).
RC
Tooling/environment. CMake configure failed with:
profiling-weekly.ymlinstalled clang/cmake/ninja but never ranconan install. GTest is supplied via Conan (gtest/1.14.0inconanfile.py) and required byfind_package(GTest REQUIRED)inCMakeLists.txt:115.Fix
Adopt the same pattern
_required.ymluses for every other C++ build job:apt-get installblock with the canonical./.github/actions/install-build-depscomposite action (installs clang-18, cmake, ninja, AND conan with a detected profile).~/.conan2keyed onhashFiles('conanfile.py').conan installstep (Release, cppstd=20) before the CMake configure.-DCMAKE_TOOLCHAIN_FILE=build/conan-deps/conan_toolchain.cmakesofind_package(GTest REQUIRED)resolves.Net change: +18 / -14 lines, scoped to
.github/workflows/profiling-weekly.ymlonly.Test plan
workflow_dispatchafter merge and confirm green