Skip to content

fix(ci): Profiling Tests (Weekly) workflow failing on main#548

Merged
mvillmow merged 1 commit into
mainfrom
fix/profiling-tests-weekly-2026-05-10
May 10, 2026
Merged

fix(ci): Profiling Tests (Weekly) workflow failing on main#548
mvillmow merged 1 commit into
mainfrom
fix/profiling-tests-weekly-2026-05-10

Conversation

@mvillmow
Copy link
Copy Markdown
Collaborator

Repairs Profiling Tests (Weekly) (run 25620831958, persistent across at least the last two weekly runs).

RC

Tooling/environment. CMake configure failed with:

CMake Error at /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
  GTEST_MAIN_LIBRARY)

profiling-weekly.yml installed clang/cmake/ninja but never ran conan install. GTest is supplied via Conan (gtest/1.14.0 in conanfile.py) and required by find_package(GTest REQUIRED) in CMakeLists.txt:115.

Fix

Adopt the same pattern _required.yml uses for every other C++ build job:

  • Replace ad-hoc apt-get install block with the canonical ./.github/actions/install-build-deps composite action (installs clang-18, cmake, ninja, AND conan with a detected profile).
  • Cache ~/.conan2 keyed on hashFiles('conanfile.py').
  • Add a conan install step (Release, cppstd=20) before the CMake configure.
  • Pass -DCMAKE_TOOLCHAIN_FILE=build/conan-deps/conan_toolchain.cmake so find_package(GTest REQUIRED) resolves.

Net change: +18 / -14 lines, scoped to .github/workflows/profiling-weekly.yml only.

Test plan

  • Trigger via workflow_dispatch after merge and confirm green

CMake configure was failing with "Could NOT find GTest (missing:
GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)" because the
workflow installed apt build tools but never ran `conan install`.
GTest is provided via Conan (gtest/1.14.0) per conanfile.py and
required by find_package(GTest REQUIRED) in CMakeLists.txt.

Switch to the canonical pattern used by _required.yml:
- Use the .github/actions/install-build-deps composite action
  (installs clang-18, cmake, ninja, AND conan with detected profile)
- Cache ~/.conan2 keyed on conanfile.py hash
- Run `conan install` for Release before cmake configure
- Pass -DCMAKE_TOOLCHAIN_FILE=build/conan-deps/conan_toolchain.cmake
  so find_package() locates GTest

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mvillmow mvillmow enabled auto-merge (squash) May 10, 2026 23:02
@mvillmow mvillmow merged commit 9cad3b1 into main May 10, 2026
20 checks passed
@mvillmow mvillmow deleted the fix/profiling-tests-weekly-2026-05-10 branch May 10, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant