feat: validateSubjectToken at gRPC boundary, in_flight Prometheus metric, ADR index cleanup#477
Merged
Merged
Conversation
✅ Dependency Audit
See the Security tab for detailed findings. Workflow: Dependency Audit |
Security Scan Results
Recommendations
Workflow: Security Scanning |
mvillmow
force-pushed
the
grpc-monitoring-bundle-m8
branch
3 times, most recently
from
aaf7851 to
ed93b26
Compare
…ric, ADR index cleanup - #279: Apply validateNatsSubjectToken() at all gRPC service methods in HMASCoordinatorServiceImpl (SubmitTask, StreamTaskStatus, GetTaskResult, SubmitResult, CancelTask, GetTaskProgress). Rejects task IDs and parent_task_ids containing path-traversal characters or other characters outside the NATS token grammar before any internal routing is attempted. - #302: Expose in_flight_count as a Prometheus gauge. Added Metrics::setInFlightCount() / getInFlightCount() (atomic int64) to core::Metrics, wired as keystone_task_claimer_in_flight_count in PrometheusExporter::generateMetrics(), and documented in include/monitoring/prometheus_exporter.hpp. - #263: Audit ADR index for references to extracted HMAS components. Added ADR-015 cross-reference notes to ADR-001, ADR-002, ADR-006, ADR-008, ADR-009, and ADR-010 clarifying that ChiefArchitectAgent, ComponentLeadAgent, ModuleLeadAgent, and TaskAgent now live in ProjectAgamemnon, while Keystone retains only transport primitives. Closes #263 Closes #279 Closes #302 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mvillmow
force-pushed
the
grpc-monitoring-bundle-m8
branch
from
ed93b26 to
e7e92ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateNatsSubjectToken()at all gRPC service method boundaries inHMASCoordinatorServiceImpl—SubmitTask,StreamTaskStatus,GetTaskResult,SubmitResult,CancelTask, andGetTaskProgress. Rejectstask_id/parent_task_idvalues containing path-traversal characters or anything outside the NATS token grammar before any internal routing occurs.in_flight_countas a Prometheus gauge. AddedMetrics::setInFlightCount()/getInFlightCount()(lock-freestd::atomic<int64_t>) tocore::Metrics, exposed askeystone_task_claimer_in_flight_countinPrometheusExporter::generateMetrics(), and documented in the exporter header.ChiefArchitectAgent,ComponentLeadAgent,ModuleLeadAgent, andTaskAgentnow live in ProjectAgamemnon while Keystone retains only transport primitives.Test plan
cmake --preset debug && cmake --build --preset debugclang-format --dry-run --Werrorclean on all modified C++ filestask_id(e.g. containing/) and verifyaccepted=falsewith a clear error message/metricsoutput includeskeystone_task_claimer_in_flight_countgauge after callingMetrics::getInstance().setInFlightCount(N)Closes #263
Closes #279
Closes #302
🤖 Generated with Claude Code