Conversation
✅ Dependency Audit
See the Security tab for detailed findings. Workflow: Dependency Audit |
Security Scan Results
Recommendations
Workflow: Security Scanning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/test_component_lead_agent.cppthat mirror the ModuleLeadAgent tests from issue Handle task.failed events to prevent DAG deadlocks #87. Tests cover: single module TASK_FAILED → ERROR state,synthesizeComponentResult()returns error string after failure, failure before all results does not deadlock, and success-after-failure still counts toward completion.NATSListenerintosrc/daemon/main.cpp. The daemon now connects to NATS viaNatsConnection, obtains ajsCtx*, constructsNATSListenerConfigfrom environment variables (KEYSTONE_NATS_URL,KEYSTONE_NATS_SUBJECT,KEYSTONE_NATS_DURABLE), callsNATSListener::start(js)during startup, and callslistener.stop()+nats_conn.disconnect()in the shutdown path. If NATS is unavailable the daemon continues running (health endpoint stays up) with a logged warning.Notes
keystone_natsandkeystone_transporttargets are assumed to already be linked into the daemon binary by the existing CMake setup.Test plan
just format-check— passessrc/daemon/main.cppctest --preset debug --output-on-failure -R ComponentLeadAgent— all 16 tests passSingleModuleFailureTransitionsToError,SynthesizeAfterModuleFailureReturnsErrorMessage,ModuleFailureBeforeAllResultsDoesNotDeadlock,SuccessResultAfterModuleFailureStillCountsTowardCompletionCloses #183
Closes #180
🤖 Generated with Claude Code