Skip to content

feat(network): max_attempts config, NatsConnection readiness probe, correlation_id field#472

Merged
mvillmow merged 1 commit into
mainfrom
nats-listener-bundle
Apr 26, 2026
Merged

feat(network): max_attempts config, NatsConnection readiness probe, correlation_id field#472
mvillmow merged 1 commit into
mainfrom
nats-listener-bundle

Conversation

@mvillmow
Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Build debug preset: cmake --preset debug && cmake --build --preset debug
  • Run unit tests: ctest --preset debug --output-on-failure
  • Verify NATSListenerConfig{.max_attempts=1} disables retries; max_attempts=3 retries up to 3 times
  • Verify HealthCheckServer constructed with nats_connection_check=[]{return false;} returns 503 on /ready
  • Verify KeystoneMessage round-trips correlation_id through MessageSerializer::serialize/deserialize
  • Format check: just format-check

Closes #331
Closes #204
Closes #285

🤖 Generated with Claude Code

@mvillmow mvillmow enabled auto-merge (rebase) April 26, 2026 00:50
@github-actions
Copy link
Copy Markdown

✅ Dependency Audit

Severity Count
Critical 0
High 0
Medium 0
Low 0

See the Security tab for detailed findings.


Workflow: Dependency Audit

@github-actions
Copy link
Copy Markdown

Security Scan Results

  • ❌ Secret Scanning: Potential secrets found
  • ✅ SAST: Completed (check Security tab for details)
  • ✅ Dependency Scanning: Completed
  • ✅ C++ Static Analysis: Completed
  • ✅ Docker Image Scanning: 0 high, 22 medium vulnerabilities (acceptable)

Recommendations

  • Review findings in the GitHub Security tab
  • Check artifact uploads for detailed reports
  • Address critical Docker vulnerabilities immediately

Workflow: Security Scanning

@mvillmow mvillmow force-pushed the nats-listener-bundle branch from b286bb9 to 38905e4 Compare April 26, 2026 14:31
…orrelation_id field

Closes #331
Closes #204
Closes #285

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mvillmow mvillmow force-pushed the nats-listener-bundle branch from 38905e4 to c486227 Compare April 26, 2026 18:30
@mvillmow mvillmow merged commit f15afd0 into main Apr 26, 2026
8 of 9 checks passed
@mvillmow mvillmow deleted the nats-listener-bundle branch April 26, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant