feat(network): max_attempts config, NatsConnection readiness probe, correlation_id field#472
Merged
Conversation
✅ Dependency Audit
See the Security tab for detailed findings. Workflow: Dependency Audit |
Security Scan Results
Recommendations
Workflow: Security Scanning |
b286bb9 to
38905e4
Compare
38905e4 to
c486227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_attemptsfield (default: 3) toNATSListenerConfig;NATSListener::start()now retriesjs_Subscribeup tomax_attemptstimes, logging each failed attempt, before returning the final error status.NatsConnectionCheckcallback type andsetNatsConnectionCheck()method toHealthCheckServer; the/readyreadiness probe now returns 503 until this callback (e.g.[&conn]{ return conn.isConnected(); }) returns true, before evaluating the customReadinessCheck.std::optional<std::string> correlation_idtoKeystoneMessagefor cross-host distributed tracing; propagated throughSerializableMessage(correlation_id+has_correlation_idfields) in bothfromKeystoneMessage()andtoKeystoneMessage().Test plan
cmake --preset debug && cmake --build --preset debugctest --preset debug --output-on-failureNATSListenerConfig{.max_attempts=1}disables retries;max_attempts=3retries up to 3 timesHealthCheckServerconstructed withnats_connection_check=[]{return false;}returns 503 on/readyKeystoneMessageround-tripscorrelation_idthroughMessageSerializer::serialize/deserializejust format-checkCloses #331
Closes #204
Closes #285
🤖 Generated with Claude Code