fix(ci): remove duplicate clang-format check#463
Closed
mvillmow wants to merge 1 commit into
Closed
Conversation
✅ Dependency Audit
See the Security tab for detailed findings. Workflow: Dependency Audit |
Security Scan Results
Recommendations
Workflow: Security Scanning |
The quality job runs both 'just format-check' (system clang-format) and 'pre-commit action' (pinned v18.1.0). The pre-commit hook is the single source of truth for C++ formatting validation, so removing the duplicate Make-based check prevents version conflicts and simplifies the job. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Superseded — this PR removed a duplicate clang-format check from |
auto-merge was automatically disabled
April 26, 2026 14:33
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #260 by removing the duplicate clang-format check from the
qualityCI job.The quality job was running two overlapping formatting checks:
just format-check(uses system clang-format version)pre-commit action(uses pinned v18.1.0)This could cause false conflicts where one passes and the other fails due to version differences. By removing the Make-based check, we establish the pre-commit hook (v18.1.0) as the single source of truth for C++ formatting validation.
Changes
.github/workflows/ci.yml.pre-commit-config.yamlTesting
just format-checkstill works locally for developersGenerated with Claude Code