Skip to content

fix(ci): remove duplicate clang-format check#463

Closed
mvillmow wants to merge 1 commit into
mainfrom
260-auto-impl
Closed

fix(ci): remove duplicate clang-format check#463
mvillmow wants to merge 1 commit into
mainfrom
260-auto-impl

Conversation

@mvillmow
Copy link
Copy Markdown
Collaborator

Summary

Resolves #260 by removing the duplicate clang-format check from the quality CI job.

The quality job was running two overlapping formatting checks:

  1. just format-check (uses system clang-format version)
  2. pre-commit action (uses pinned v18.1.0)

This could cause false conflicts where one passes and the other fails due to version differences. By removing the Make-based check, we establish the pre-commit hook (v18.1.0) as the single source of truth for C++ formatting validation.

Changes

  • Removed the "Check formatting" step from the quality job in .github/workflows/ci.yml
  • Pre-commit continues to enforce clang-format v18.1.0 as configured in .pre-commit-config.yaml

Testing

  • ✅ Verified just format-check still works locally for developers
  • ✅ Pre-commit hook remains active for CI validation

Generated with Claude Code

@mvillmow mvillmow enabled auto-merge (rebase) April 26, 2026 00:27
@github-actions
Copy link
Copy Markdown

✅ Dependency Audit

Severity Count
Critical 0
High 0
Medium 0
Low 0

See the Security tab for detailed findings.


Workflow: Dependency Audit

@github-actions
Copy link
Copy Markdown

Security Scan Results

  • ❌ Secret Scanning: Potential secrets found
  • ✅ SAST: Completed (check Security tab for details)
  • ✅ Dependency Scanning: Completed
  • ✅ C++ Static Analysis: Completed
  • ✅ Docker Image Scanning: 0 high, 22 medium vulnerabilities (acceptable)

Recommendations

  • Review findings in the GitHub Security tab
  • Check artifact uploads for detailed reports
  • Address critical Docker vulnerabilities immediately

Workflow: Security Scanning

The quality job runs both 'just format-check' (system clang-format) and
'pre-commit action' (pinned v18.1.0). The pre-commit hook is the single
source of truth for C++ formatting validation, so removing the duplicate
Make-based check prevents version conflicts and simplifies the job.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mvillmow
Copy link
Copy Markdown
Collaborator Author

Superseded — this PR removed a duplicate clang-format check from .github/workflows/ci.yml, but ci.yml was deleted on main in commit 6dd4bf7 (CI consolidated into _required.yml). The fix is no longer applicable. Closing.

@mvillmow mvillmow closed this Apr 26, 2026
auto-merge was automatically disabled April 26, 2026 14:33

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconcile duplicate C++ formatting: quality job vs pre-commit job

1 participant