fix(exporter): hi_jetstream_events_total is a Counter (#172)#517
Merged
Conversation
) Render hi_jetstream_events_total and hi_jetstream_consumer_last_seq with '# TYPE ... counter' so Prometheus's rate() applies counter-reset detection (e.g. when a consumer restarts and the value drops back to zero). The underlying accumulators already behave monotonically — only the exposition type was wrong. hi_jetstream_task_latency_seconds, hi_jetstream_consumer_connected, and hi_jetstream_consumer_scrape_timestamp remain gauges (instantaneous values). Closes #172 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hi_jetstream_events_totalandhi_jetstream_consumer_last_seqas Prometheuscountertypes instead ofgauge. Both values already accumulate monotonically in the consumer (_event_counts[k] += 1,_last_seqis a high-water mark), so only the exposition# TYPEline was wrong.rate()queries — after a consumer restart, the value drops to 0; with the oldgaugetype,rate()produced a misleading spike instead of treating the drop as a reset.hi_jetstream_task_latency_seconds,hi_jetstream_consumer_connected, andhi_jetstream_consumer_scrape_timestampremain gauges (they are instantaneous values, not monotonic).Closes #172
Test plan
pytest tests/test_jetstream_consumer.py— 35/35 pass# TYPE hi_jetstream_events_total counterand# TYPE hi_jetstream_consumer_last_seq countergaugeTYPE line is no longer emitted for these metricshi_jetstream_task_latency_seconds,hi_jetstream_consumer_connected) retain theirgaugeTYPE linesCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com